Re: [PATCH] powerpc/powernv: handle OPAL_SUCCESS return in opal_sensor_read
From: Stewart Smith <hidden>
Date: 2015-03-25 23:07:20
From: Stewart Smith <hidden>
Date: 2015-03-25 23:07:20
C=C3=A9dric Le Goater [off-list ref] writes:
Currently, when a sensor value is read, the kernel calls OPAL, which in turn builds a message for the FSP, and waits for a message back.=20 The new device tree for OPAL sensors [1] adds new sensors that can be=20 read synchronously (core temperatures for instance) and that don't need=20 to wait for a response. This patch modifies the opal call to accept an OPAL_SUCCESS return value and cover the case above. [1] https://lists.ozlabs.org/pipermail/skiboot/2015-March/000639.html Signed-off-by: C=C3=A9dric Le Goater <redacted> --- We still uselessly reserve a token (for the response) and take a lock, which might raise the need of a new 'opal_sensor_read_sync'=20 call.
Actually.... why do we take a lock around the OPAL calls at all?