Re: [PATCH] powerpc/fsl: add power_off support for fsl platform

On Wed, 2015-02-04 at 14:47 +0800, Dongsheng Wang wrote:

+void ppc_md_fixup(void)
+{

This name is way too generic (though it's moot since you shouldn't use
ppc_md for this).

+	struct device_node *np;
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");
+	if (!np)
+		return;
+
+	of_node_put(np);
+
+	pm_power_off = fsl_power_off;
+	ppc_md.halt = fsl_power_off;
+}

Please implement this as a drivers/power/reset driver, and consider
basing on top of
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/293089.html

-Scott