Re: [PATCH V11 07/17] powerpc/pci: Don't unset pci resources for VFs
From: Benjamin Herrenschmidt <hidden>
Date: 2015-02-10 00:37:25
Also in:
linux-pci
On Thu, 2015-01-15 at 10:27 +0800, Wei Yang wrote:
If we're going to reassign resources with flag PCI_REASSIGN_ALL_RSRC, all resources will be cleaned out during device header fixup time and then get reassigned by PCI core. However, the VF resources won't be reassigned and thus, we shouldn't clean them out. This patch adds a condition. If the pci_dev is a VF, skip the resource unset process.
I don't understand this, can you elaborate ? Why wouldn't we reassign the IOV resource just like everything else ? Ben.
quoted hunk ↗ jump to hunk
Signed-off-by: Wei Yang <redacted> --- arch/powerpc/kernel/pci-common.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c index 37d512d..889f743 100644 --- a/arch/powerpc/kernel/pci-common.c +++ b/arch/powerpc/kernel/pci-common.c@@ -788,6 +788,10 @@ static void pcibios_fixup_resources(struct pci_dev *dev) pci_name(dev)); return; } + + if (dev->is_virtfn) + return; + for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { struct resource *res = dev->resource + i; struct pci_bus_region reg;