Re: [RFC 02/11] i2c: add quirk checks to core

On Mon, Jan 12, 2015 at 12:08:14PM +0000, Russell King - ARM Linux wrote:

On Fri, Jan 09, 2015 at 06:21:32PM +0100, Wolfram Sang wrote:

quoted

+static int i2c_quirk_error(struct i2c_adapter *adap, struct i2c_msg *msg, char *err_msg)
+{
+	dev_err(&adap->dev, "quirk: %s (addr 0x%04x, size %u)\n", err_msg, msg->addr, msg->len);
+	return -EOPNOTSUPP;
+}

So, what happens if I open an I2C adapter, find a message which causes
i2c_quirk_error() to be called, and then spin repeatedly calling that...
Shouldn't there be some rate limiting to this?

Can be argued. Changed to dev_err_ratelimited(). Thanks!