Re: [PATCH 0/7] Serialise oopses, BUGs, WARNs, dump_stack, soft lockups and hard lockups
From: Russell King - ARM Linux <hidden>
Date: 2015-02-24 10:44:44
Also in:
linux-arm-kernel, lkml
From: Russell King - ARM Linux <hidden>
Date: 2015-02-24 10:44:44
Also in:
linux-arm-kernel, lkml
On Tue, Feb 24, 2015 at 01:39:46AM -0800, Arjan van de Ven wrote:
one of the question is if you want to serialize, or if you just want to label. If you take a cookie (could just be a monotonic increasing number) at the start of the oops and then prefix/postfix the stack printing with that number, you don't serialize (risk of locking up), but you can pretty trivially see which line came from where.. if you do the monotonic increasing number approach, you even get an ordering out of it. it does mean changing the dump_stack() and co function fingerprint to take an extra argument, but that is not TOO insane.
I like that idea, but it relies on ensuring that each line is printed by one printk() statement - which in itself is a good idea. I'd actually like a version of print_hex_dump() which we could use for stack and code dumping - the existing print_hex_dump() assumes that it's fine to dereference the pointer, whereas for stack and code dumping, we can't always make that assumption. That's a separate issue though. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.