Re: [PATCH 1/3] CXL: Add image control to sysfs
From: Michael Ellerman <hidden>
Date: 2015-01-15 05:07:18
On Thu, 2015-01-15 at 15:41 +1100, Ian Munsie wrote:
Excerpts from Ryan Grimm's message of 2015-01-15 13:56:39 +1100:quoted
Add reset_loads_image and reset_image_select to sysfs. reset_image_select identifies which image will be loaded to the card on the next PERST. Valid entries are: "user" and "factory". reset_loads_image defines functionality on a PERST. Value of 0 means PERST will not cause image load. A power cycle is required to load the image. Value of 1 means PERST will cause image load. sysfs updates the cxl struct in the driver then calls cxl_update_image_control to write the vals in the VSEC.Let's combine both of these into a single sysfs file, with "none", "user" and "factory" options and have the show & read functions handle mapping those three options to the two bits in the register. Of the two names I'd probably go with reset_image_select.
Three words, all can be verbs, two can be nouns, it's not too clear. Maybe "load_image_on_perst" ? cheers