Re: [PATCH V2] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug
From: Thomas Gleixner <hidden>
Date: 2015-01-20 10:01:04
Also in:
lkml
On Tue, 20 Jan 2015, Preeti U Murthy wrote:
quoted hunk ↗ jump to hunk
--- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c@@ -675,8 +675,8 @@ static void broadcast_move_bc(int deadcpu) if (!bc || !broadcast_needs_cpu(bc, deadcpu)) return; - /* This moves the broadcast assignment to this cpu */ - clockevents_program_event(bc, bc->next_event, 1); + /* This allows fresh nomination of broadcast cpu */
This comment should explain WHY this enforces the move of the broadcast to a different cpu. 'Allows' is rather ambiguous.
+ bc->next_event.tv64 = KTIME_MAX;
Thanks, tglx