Re: [PATCH] powerpc/kernel: Make syscall_exit a local label
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2014-12-15 03:03:23
On Fri, 2014-12-05 at 10:27 +0000, David Laight wrote:
From: Michael Ellermanquoted
diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index 0905c8da90f1..d8828e50dbef 100644 --- a/arch/powerpc/kernel/entry_64.S +++ b/arch/powerpc/kernel/entry_64.S@@ -178,7 +178,7 @@ system_call: /* label this so stack traces look sane */ mtctr r12 bctrl /* Call handler */Why not add a 'nop' here instead?
Because we'd rather not add extra instructions to the syscall path unless we really need to. A local label seems like the preferable solution to me. cheers