Re: [PATCH] i2c: mpc: add register documentation to Freescale I2C driver
From: Wolfram Sang <hidden>
Date: 2014-12-01 17:22:01
Also in:
linux-i2c
Attachments
- signature.asc [application/pgp-signature] 819 bytes
From: Wolfram Sang <hidden>
Date: 2014-12-01 17:22:01
Also in:
linux-i2c
On Sat, Nov 29, 2014 at 01:58:42PM -0800, Danielle Costantino wrote:
i2c: mpc: add register documentation to Freescale I2C driver
This should be in one patch.
return -ETIMEDOUT for all time-out error conditions
This should be in a seperate patch.
and warn on arbitration lost.
And this should be dropped. "Arbitration lost" lost is not an error, it is specified behaviour of I2C.
if (!(cmd_err & CSR_MCF)) {
- dev_dbg(i2c->dev, "unfinished\n");
+ dev_warn(i2c->dev, "unfinished\n");Are you sure this helps a regular user?