Re: [v3] i2c: Driver to expose PowerNV platform i2c busses

From
Michael Ellerman <mpe@ellerman.id.au>
Date
2014-12-12 05:30:48
Also in
linux-devicetree, linux-i2c
On Tue, 2014-12-09 at 21:21 +1100, Benjamin Herrenschmidt wrote:
On Tue, 2014-12-09 at 20:45 +1100, Michael Ellerman wrote:
quoted
On Mon, 2014-08-12 at 06:36:16 UTC, Neelesh Gupta wrote:
quoted
The patch exposes the available i2c busses on the PowerNV platform
to the kernel and implements the bus driver to support i2c and
smbus commands.
The driver uses the platform device infrastructure to probe the busses
on the platform and registers them with the i2c driver framework.
quoted
 arch/powerpc/include/asm/opal.h                    |   29 ++
 arch/powerpc/platforms/powernv/opal-wrappers.S     |    1 
 arch/powerpc/platforms/powernv/opal.c              |   11 +
This had major conflicts in the above files.

I've fixed it up but please check I did it correctly:

  https://github.com/mpe/powerpc-merge/commits/pw/neelesh-i2c

It also doesn't build as a module:

  $ grep CONFIG_I2C_OPAL .config
  CONFIG_I2C_OPAL=m
  $ make ...
  ...
  ERROR: "opal_i2c_request" [drivers/i2c/busses/i2c-opal.ko] undefined!
Right that needs to be exported, however for those OPAL wrappers to work
when exported as modules on an LE kernel with ABI v2 (pfiew !) we need
another patch from jk to sort out the external entry to the asm...

Jeremy, is that already in or not yet ?
Yeah it's been in since October.

Please send a v4 with a fix for this Neelesh.

cheers
Thread (1 message) 1 message, 1 author, last reply 2014-12-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help