Thread (7 messages) flat view 7 messages, 5 authors, 2014-12-01

Re: [PATCH v2] slab: Fix nodeid bounds check for non-contiguous node IDs

From: Pekka Enberg <hidden>
Date: 2014-12-01 09:22:32
Also in: linux-mm, lkml

On 12/1/14 6:28 AM, Paul Mackerras wrote:
quoted hunk ↗ jump to hunk
---
v2: include the oops message in the patch description

  mm/slab.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slab.c b/mm/slab.c
index eb2b2ea..f34e053 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3076,7 +3076,7 @@ static void *____cache_alloc_node(struct kmem_cache *cachep, gfp_t flags,
  	void *obj;
  	int x;
  
-	VM_BUG_ON(nodeid > num_online_nodes());
+	VM_BUG_ON(nodeid < 0 || nodeid >= MAX_NUMNODES);
  	n = get_node(cachep, nodeid);
  	BUG_ON(!n);
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help