On Wed, Nov 26, 2014 at 03:07:51PM +1100, Michael Ellerman wrote:

On Mon, 2014-24-11 at 22:26:59 UTC, Gavin Shan wrote:

quoted

The flag passed to ioda_eeh_phb_reset() should be EEH_RESET_DEACTIVATE,
which is translated to OPAL_DEASSERT_RESET or something else by the
EEH backend accordingly.

The patch replaces OPAL_DEASSERT_RESET with EEH_RESET_DEACTIVATE for
ioda_eeh_phb_reset().

What is the symptom? Does it not work at all or is it just a cosmetic issue?
ie. should I send this to Linus ASAP or can it wait for the next release.

Looks like this went in as 361f2a2a1536 ("powrpc/powernv: Reset PHB in kdump
kernel") in 3.16. Should it go to stable?

It's just a cosmetic issue and please pick it up for next release.

Thanks,
Gavin

cheers