Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2014-11-03 23:43:49
Also in:
netdev
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2014-11-03 23:43:49
Also in:
netdev
On Mon, 2014-11-03 at 09:21 -0800, Alexei Starovoitov wrote:
On Mon, Nov 3, 2014 at 9:06 AM, David Miller [off-list ref] wrote:quoted
From: Denis Kirjanov <redacted> Date: Thu, 30 Oct 2014 09:12:15 +0300quoted
Add BPF extension SKF_AD_PKTTYPE to ppc JIT to load skb->pkt_type field. Before: [ 88.262622] test_bpf: #11 LD_IND_NET 86 97 99 PASS [ 88.265740] test_bpf: #12 LD_PKTTYPE 109 107 PASS After: [ 80.605964] test_bpf: #11 LD_IND_NET 44 40 39 PASS [ 80.607370] test_bpf: #12 LD_PKTTYPE 9 9 PASS CC: Alexei Starovoitov<redacted> CC: Michael Ellerman<mpe@ellerman.id.au> Cc: Matt Evans <redacted> Signed-off-by: Denis Kirjanov <redacted> v2: Added test rusultsSo, can I apply this now?I think this question is more towards ppc folks, since both Daniel and myself said before that it looks ok.
Yeah sorry, as I said I don't really know enough about BPF to ack it.
Philippe just tested the previous version of this patch on ppc64le... I'm guessing that Matt (original author of bpf jit for ppc) is not replying, because he has no objections.
Actually that might be because he works at ARM now :) If you can CC Philippe on future BPF patches for powerpc that would probably help. cheers