Re: [PATCH v2 07/14] of/reconfig: Always use the same structure for notifiers
flat view
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-11-25 23:08:26
Also in:
linux-devicetree, lkml
On Mon, 2014-11-24 at 22:33 +0000, Grant Likely wrote:
The OF_RECONFIG notifier callback uses a different structure depending on whether it is a node change or a property change. This is silly, and not very safe. Rework the code to use the same data structure regardless of the type of notifier.
I fell pretty good about this one except...
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index b9d1dfdbe5bb..9fe6002c1d5a 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c@@ -1711,12 +1711,11 @@ static void stage_topology_update(int core_id) static int dt_update_callback(struct notifier_block *nb, unsigned long action, void *data) { - struct of_prop_reconfig *update; + struct of_reconfig_data *update = data; int rc = NOTIFY_DONE; switch (action) { case OF_RECONFIG_UPDATE_PROPERTY: - update = (struct of_prop_reconfig *)data;
Should we assert/bug on !update->dn / update->prop ? (Same for the rest of the patch) Or do you reckon it's pointless ? Ben.