Re: [PATCH] [powerpc] Fix Text randomization

On Tue, 2014-11-18 at 12:50 +0530, Vineeth Vijayan wrote:

On Mon, Nov 17, 2014 at 12:23 PM, Michael Ellerman [off-list ref] wrote:

quoted

On Fri, 2014-11-14 at 14:42 +0530, Vineeth Vijayan wrote:

quoted

Now there is no way to disable TEXT randomization on a PPC32/PPC64
machine. Text randomization happens even in the case of "echo 0 >
/proc/sys/kernel/randomize_va_space"

This happens due to the incorrect definition of ELF_ET_DYN_BASE
at arch/powerpc/include/asm/elf.h

The function randomize_et_dyn is redundant and is removed.

The patch looks OK, but for the change log I was thinking something more like
this:


powerpc: Use generic PIE randomization

Ok. Thats better.
Do you want me to send a new patch with updated change log as mentioned ?

 
No that's OK, I've already merged it.

cheers