Re: powerpc/8xx: Remove Kconfig symbol FADS

On Fri, 2014-11-07 at 09:48 +0100, Paul Bolle wrote:

On Thu, 2014-11-06 at 21:50 -0600, Scott Wood wrote:

quoted

On Wed, Sep 24, 2014 at 10:06:19AM +0200, Paul Bolle wrote: 

quoted

Another cleanup might be to remove MPC8XXFADS (or "FADS") from the "8xx
Machine Type" choice. Is there any reason left to pick "FADS" as a
machine type?

Nothing references MPC8XXFADS, so yes, it can be removed.

I'll try to look into this. For the (verbose) reasons below I'll do that
in a separate patch, if I ever get that far. What follows is mostly a
note to self.

Yes, make it a separate patch -- I've already got this patch queued up.

MPC8XXFADS is indeed not referenced anywhere. But it's one of the
entries in the "8xx Machine Type" choice. And it's common for choice
blocks the have a "none of the above" entry. Ie, an entry that allows to
configure nothing. There's a chance MPC8XXFADS is currently used for
that role. (This is easier to determine for people that - unlike me -
know what all the symbols in this choice mean. To me they 're basically
random strings.)

It's not a "none of the above" option.  It's a board type that was
supported in arch/ppc, and only some remnants made it over to
arch/powerpc.  If you don't pick a machine type that results in a
define_machine() struct (with a probe function that matches the device
tree), the kernel will not boot.

-Scott