Thread (6 messages) 6 messages, 4 authors, 2014-10-17

Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

flat view

From: Seth Jennings <hidden>
Date: 2014-10-17 08:04:57

On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote:
quoted
On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote:
quoted
Check old_devdata->dev in nx-842 driver before accessing it, as
on systems without any nx-842 hardware, the ->dev will never be
set.  Currently, the module will cause an oops during unload
since old_devdata->dev is null.
Hi Dan,

Patch looks reasonable. But I can't merge it, at least not without an
ACK:

$ ./scripts/get_maintainer.pl -f drivers/crypto/nx/
Nathan Fontenot [off-list ref] (supporter:IBM Power 842
com...)
Marcelo Henrique Cerri [off-list ref] (supporter:IBM Power
in-Nest...)
Fionnuala Gunter [off-list ref] (supporter:IBM Power
in-Nest...)
Herbert Xu [off-list ref] (maintainer:CRYPTO API)
"David S. Miller" [off-list ref] (maintainer:CRYPTO API)
linux-crypto@vger.kernel.org (open list:IBM Power in-Nest...)
linux-kernel@vger.kernel.org (open list)


If any of the above is out of date please send me a patch for
MAINTAINERS.
I think Dan now owns that driver, Dan, please confirm.
I guess I'm not on the maintainer list anymore, as I shouldn't be
since I don't work at IBM anymore.

So... yeah.  I was the original co-author of driver so I acked it
but I'm not the maintainer anymore.  Which I shouldn't be, since
I don't work at IBM anymore.

Seth
Cheers,
Ben.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help