Thread (11 messages) 11 messages, 3 authors, 2014-10-03

Re: [1/4] powerpc/powernv: Sync header with firmware

From: Stewart Smith <hidden>
Date: 2014-10-03 05:30:39

Michael Ellerman [off-list ref] writes:
quoted
+	OpalEjtIoaDmaWriteMemTarget	= 19,
+};
I realise these come from the skiboot source, but they're just too ugly.

Please use kernel style naming, like most of the rest of the file, eg:

	OPAL_ERR_INJECT_IOA_BUS_ERR
You know what, I think I'd feel better if we changed skiboot source to
be like this too. Many of the other enums in skiboot are kernel style
and not camel. So, I'm going to go do that, then kernel and firmware can
match.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help