Re: [PATCH] CXL: Fix PSL error due to duplicate segment table entries
From: Ian Munsie <hidden>
Date: 2014-10-28 00:20:22
Also in:
lkml
From: Ian Munsie <hidden>
Date: 2014-10-28 00:20:22
Also in:
lkml
Excerpts from Aneesh Kumar K.V's message of 2014-10-28 01:38:41 +1100:
I guess you are missing too many fixes in one patch. 1) One cleanup 2) Fix for masking ea correctly 3) And fix for not erroring out when a slb is already in the slb cache.
ok, I'll split it up
quoted
+/* This finds a free SSTE and checks to see if it's already in table */ +static struct cxl_sste* find_free_sste(struct cxl_context *ctx, + struct copro_slb *slb)the name is confusing. If you want to keep the name, can you also specify that it return NULL, if it finds a matching entry. IIUC that is the real part of the fix for the problem mentioned ?
Good point.
quoted
- sr = CXL_PSL_SR_An_SC; + sr = 0;What is this change about ?
That tells the PSL not to use the secondary hash since we are no longer filling out any entries using it. I'll clarify that in the commit message when I split this out. Cheers, -Ian