Thread (2 messages) flat view 2 messages, 1 author, 2014-09-16
STALE4367d

[PATCH 2/2] powerpc/via-pmu: fix OF node leak in Keylargo init

From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: 2014-09-16 22:07:30
Subsystem: linux for power macintosh, the rest · Maintainer: Linus Torvalds

From: Phil Carmody <redacted>

If we of_find_node_by_name() then we must of_node_put() too.

Signed-off-by: Phil Carmody <redacted>
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
 drivers/macintosh/via-pmu.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 6221235..aed3cb0 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -329,6 +329,7 @@ int __init find_via_pmu(void)
 				gaddr = of_translate_address(gpiop, reg);
 			if (gaddr != OF_BAD_ADDR)
 				gpio_reg = ioremap(gaddr, 0x10);
+			of_node_put(gpiop);
 		}
 		if (gpio_reg == NULL) {
 			printk(KERN_ERR "via-pmu: Can't find GPIO reg !\n");
-- 
2.1.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help