Thread (3 messages) flat view 3 messages, 2 authors, 2014-09-15

Re: [PATCH] powerpc: Add macros for the ibm_architecture_vec[] lengths

From: Stewart Smith <hidden>
Date: 2014-09-09 01:03:13

Michael Ellerman [off-list ref] writes:
The encoding of the lengths in the ibm_architecture_vec array is
"interesting" to say the least. It's non-obvious how the number of bytes
we provide relates to the length value.

In fact we already got it wrong once, see 11e9ed43ca8a "Fix up
ibm_architecture_vec definition".

So add some macros to make it (hopefully) clearer. These at least have
the property that the integer present in the code is equal to the number
of bytes that follows it.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Seems at least as correct as the code was before... so,

Reviewed-by: Stewart Smith <redacted>

(not actually compiled or tested or anything, but my internal C
preprocesser says it looks okay :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help