Re: [PATCH] drivers: char: hw_random: printk replacement

On Mon, Sep 15, 2014 at 07:41:23PM +0800, Herbert Xu wrote:

On Thu, Aug 28, 2014 at 08:32:58PM +0530, Sudip Mukherjee wrote:

quoted

as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros

Signed-off-by: Sudip Mukherjee <redacted>

Your patch doesn't even build:

  CC [M]  drivers/char/hw_random/intel-rng.o
  CC [M]  drivers/char/hw_random/amd-rng.o
  CC [M]  drivers/char/hw_random/via-rng.o
  drivers/char/hw_random/intel-rng.c: In function ‘intel_init_hw_struct’:
  drivers/char/hw_random/intel-rng.c:317:3: error: expected ‘)’ before ‘warning’
  drivers/char/hw_random/intel-rng.c:308:36: warning: unused variable ‘warning’ [-Wunused-variable]
  make[1]: *** [drivers/char/hw_random/intel-rng.o] Error 1

Cheers,
-- 

i am extremely sorry for the mess. after applying the patch i tested with allmodconfig
and seeing no error i thought it was ok. but now after your mail when i am verifying i
noticed that allmodconfig is not including it in the config and as a result it was not tested.

i will post a corrected v2 of the patch.

sorry again,

thanks
sudip

Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt