Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module

On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote:

On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote:

quoted

Move the ipg clock enable and disable operation to startup and shutdown,
that is only enable ipg clock when ssi is working. Keep clock is disabled
when ssi is in idle.
otherwise, _fsl_ssi_set_dai_fmt function need to be called in probe,
so add ipg clock control for it.

It seems to be no objection so far against my last suggestion to
use regmap's mmio_clk() for named ipg clk only. So you may still
consider about that.

I think mmio_clk() can be put to another patch. and this patch only for clk_enable()
and clk_disable() operation.
 

Anyway, I'd like to do thing in parallel. So I just simply tested
it on my side and its works fine, it may still need to be tested
by others though.

Nicolina

Hi Markus

could you please review it, and share your comments?

wang shengjiu