Thread (26 messages) flat view 26 messages, 6 authors, 2014-09-11

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

From: Timur Tabi <hidden>
Date: 2014-09-09 15:24:06
Also in: alsa-devel, lkml

On 09/09/2014 10:21 AM, Mark Brown wrote:
quoted
if (ssi_private->clk)
quoted
clk_prepare_enable(ssi_private->clk);
Should be a !IS_ERR() - NULL is a valid clock.
In that case, ssi_private->clk needs to be initialized to -EINVAL or 
something, so that the check works on systems that don't have any clocks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help