Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

On Sunday 03 August 2014 09:21 PM, Segher Boessenkool wrote:

quoted

+/*
+ * KVMPPC_INST_BOOK3S_DEBUG is debug Instruction for supporting Software Breakpoint.
+ * Based on PowerISA v2.07, Instruction with opcode 0s will be treated as illegal
+ * instruction.
+ */

"primary opcode 0" instead?

ok sure.

quoted

+#define OP_ZERO                 0x0

Using 0x0 where you mean 0, making a #define for 0 in the first place...
This all looks rather silly doesn't it.

I wanted to avoid zero mentioned in the case statement, but can add a
comment explaining it.

quoted

+	case OP_ZERO:
+		if((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) {

You either shouldn't mask at all here, or the mask is wrong (the primary
op is the top six bits, not the top eight).

Yes. I guess I dont need to check here. Will resend the patch.

Thanks for review
Regards
Maddy

Segher