Re: [PATCH 1/5] kexec: Fix make headers_check
From: Vivek Goyal <vgoyal@redhat.com>
Date: 2014-08-25 17:23:34
Also in:
kexec, lkml
On Fri, Aug 22, 2014 at 06:39:47PM +0000, Geoff Levand wrote:
Remove the unneded declaration for a kexec_load() routine. Fixes errors like these when running 'make headers_check': include/uapi/linux/kexec.h: userspace cannot reference function or variable defined in the kernel Signed-off-by: Geoff Levand <geoff@infradead.org>
I think Paul Bolle tried to remove this in the past and maximilian had objections. http://lists.infradead.org/pipermail/kexec/2014-January/010902.html I can't see that how exporting kernel prototype helps here. kexec-tools seems to be using syscall(__NR_kexec_load) directly for non-xen case. So I would be fine with removing this definition. Just trying to make sure that it does not break any other library or users of this declaration. Thanks Vivek
quoted hunk ↗ jump to hunk
--- include/uapi/linux/kexec.h | 6 ------ 1 file changed, 6 deletions(-)diff --git a/include/uapi/linux/kexec.h b/include/uapi/linux/kexec.h index 6925f5b..99048e5 100644 --- a/include/uapi/linux/kexec.h +++ b/include/uapi/linux/kexec.h@@ -55,12 +55,6 @@ struct kexec_segment { size_t memsz; }; -/* Load a new kernel image as described by the kexec_segment array - * consisting of passed number of segments at the entry-point address. - * The flags allow different useage types. - */ -extern int kexec_load(void *, size_t, struct kexec_segment *, - unsigned long int); #endif /* __KERNEL__ */ #endif /* _UAPILINUX_KEXEC_H */-- 1.9.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec