Re: [PATCH] net: ugg_geth: Fix build error in -next

On 08/10/2014 11:36 AM, Uwe Kleine-König wrote:

Hello Guenter,

On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote:

quoted

powerpc:mpc83xx_defconfig and other builds fail with

drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove':
drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error:
	'struct ucc_geth_private' has no member named 'info'
   of_node_put(ugeth->info->tbi_node);
                      ^
drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error:
	     'struct ucc_geth_private' has no member named 'info'
   of_node_put(ugeth->info->phy_node);
   		     ^

Introduced by commit "net: ucc_geth: drop acquired references in probe error
path and remove".

 From the context, it appears that the variable is named ug_info.

Cc: Uwe Kleine-König <redacted>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Only seen in -next.

My patch was only sent just now, but it has the subject right:

Excellent.

	http://mid.gmane.org/1407695525-32227-1-git-send-email-u.kleine-koenig@pengutronix.de

The link doesn't seem to work for some reason.

Another upside is that it contains a Fixes: header.

Even better. I need to start using that.

Other than that my patch is the same. In case davem picks up yours:

Acked-by: Uwe Kleine-König <redacted>

I don't need the glory ;-). Dave, please pick Uwe's patch.

Thanks,
Guenter