On Tue, 2014-08-05 at 19:16 +1000, Benjamin Herrenschmidt wrote:

On Mon, 2014-08-04 at 23:13 +0300, Andrey Utkin wrote:

quoted

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81631
Reported-by: David Binderman <redacted>
Signed-off-by: Andrey Utkin <redacted>

Thanks, I wonder how that managed to remain unnoticed for so long !

1. No one tested it :)
2. The code stupidly initialises ret at the beginning of the function, so the
   compiler can't help us detect the unitialised usage.
3. NOTIFY_OK and NOTIFY_DONE appear to be equivalent in practice.

cheers