Re: [PATCH v3 12/18] powerpc/iommu: Fix missing permission bits in iommu_put_tce_user_mode()
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-07-28 01:46:13
On Thu, 2014-07-24 at 18:48 +1000, Alexey Kardashevskiy wrote:
This adds missing permission bits to the translated TCE.
Is this a bug fix for existing stuff ? If yes, submit it separately.
quoted hunk ↗ jump to hunk
Signed-off-by: Alexey Kardashevskiy <redacted> --- arch/powerpc/kernel/iommu.c | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c index 0cda2e8..5af2319 100644 --- a/arch/powerpc/kernel/iommu.c +++ b/arch/powerpc/kernel/iommu.c@@ -1088,6 +1088,7 @@ int iommu_put_tce_user_mode(struct iommu_table *tbl, unsigned long entry, return -EFAULT; } hwaddr = (unsigned long) page_address(page) + offset; + hwaddr |= tce & (TCE_PCI_READ | TCE_PCI_WRITE); ret = iommu_tce_build(tbl, entry, hwaddr, direction); if (ret)