Re: [PATCH 1/2] powerpc/powernv: Change BUG_ON to WARN_ON in elog code
From: Stewart Smith <hidden>
Date: 2014-07-23 13:07:32
From: Stewart Smith <hidden>
Date: 2014-07-23 13:07:32
Vasant Hegde [off-list ref] writes:
We can continue to read the error log (up to MAX size) even if we get the elog size more than MAX size. Hence change BUG_ON to WARN_ON. Also updated error message. Reported-by: Gopesh Kumar Chaudhary <redacted> Signed-off-by: Vasant Hegde <redacted> Signed-off-by: Ananth N Mavinakayanahalli <redacted> Acked-by: Deepthi Dharwar <redacted>
So, it turns out the BUG_ON actually caught an FSP bug, at the very least in their documentation. The WARN_ON is probably the best thing we can do, along with the OPAL/skiboot side fixes that I've mentioned separately. Acked-by: Stewart Smith <redacted>