-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, June 26, 2014 7:35 AM
To: Liu Shengzhou-B36685
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [3/3,v4] powerpc/t2080rdb: Add T2080RDB board support
=20
On Wed, Jun 11, 2014 at 06:10:06PM +0800, Shengzhou Liu wrote:

quoted

+				i2c@0 {
+					#address-cells =3D <1>;
+					#size-cells =3D <0>;
+					reg =3D <0x0>;
+
+					sfp@50 {
+						compatible =3D "optics,sfp";
+						reg =3D <0x50>;
+					};
+				};

=20
What is "sfp"?  Please use generic node names when possible.
=20
I'm not able to easily find what chip this is referring to by googling
"optics sfp".  I suspect this compatible is too vague -- what is the
actual part number?  Could you provide a URL to a description of the chip=

?

=20
If "optics" is the correct vendor name, it needs to go into vendor-prefix=

es.txt.

=20
-Scott

[Shengzhou] SFP is "Small Form-factor Pluggable transceiver" for 10Gpbs opt=
ics module.  Actually, there is no a specific vendor for this case, it is a=
 general sfp cage to which we can plug in different optics module from diff=
erent vendors.  And there is no need to configure it by SW. =20