Hi Tobias,

On Thu, Jul 24, 2014 at 05:20:45PM +0200, Tobias Klauser wrote:

On 2014-07-24 at 10:35:29 +0200, Nicolin Chen [off-list ref] wrote:

quoted

The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a
signal associated with an input clock into a signal associated with a different
output clock. The driver currently works as a Front End of DPCM with other Back
Ends DAI links such as ESAI<->CS42888 and SSI<->WM8962 and SAI. It converts the
original sample rate to a common rate supported by Back Ends for playback while
converts the common rate of Back Ends to a desired rate for capture. It has 3
pairs to support three different substreams within totally 10 channels.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---

[...]

quoted

--- /dev/null
+++ b/sound/soc/fsl/fsl_asrc.c

@@ -0,0 +1,1031 @@

[...]

quoted

+static struct platform_driver fsl_asrc_driver = {
+	.probe = fsl_asrc_probe,
+	.driver = {
+		.name = "fsl-asrc",
+		.owner = THIS_MODULE,

Not necessary, this will be set by module_platform_driver (or
the expansion of platform_driver_register, respectively).

quoted

+		.of_match_table = fsl_asrc_ids,
+		.pm = &fsl_asrc_pm,
+	},
+};
+module_platform_driver(fsl_asrc_driver);

[...]

quoted

--- /dev/null
+++ b/sound/soc/fsl/fsl_asrc_dma.c

@@ -0,0 +1,384 @@

[...]

quoted

+static int fsl_asrc_dma_pcm_new(struct snd_soc_pcm_runtime *rtd)
+{
+	struct snd_card *card = rtd->card->snd_card;
+	struct snd_pcm_substream *substream;
+	struct snd_pcm *pcm = rtd->pcm;
+	u64 dma_mask = DMA_BIT_MASK(32);
+	int ret, i;
+
+	if (!card->dev->dma_mask)
+		card->dev->dma_mask = &dma_mask;

dma_mask will go out of scope after fsl_asrc_dma_pcm_new returns,
resulting in a stray pointer in card->dev->dma_mask.

Will fix them in v3.

Thank you
Nicolin