Re: [RFC PATCH V3 06/17] ppc/pnv: allocate pe->iommu_table dynamically
From: Alexey Kardashevskiy <hidden>
Date: 2014-06-25 04:12:42
Also in:
linux-pci
On 06/25/2014 11:12 AM, Wei Yang wrote:
On Tue, Jun 24, 2014 at 08:06:32PM +1000, Alexey Kardashevskiy wrote:quoted
On 06/10/2014 11:56 AM, Wei Yang wrote:quoted
Current iommu_table of a PE is a static field. This will have a problem when iommu_free_table is called.What kind of problem? This table is per PE and PE is not going anywhere.Yes, for Bus PE, they will always sit in the system. When VF PE introduced, they could be released on the fly. When they are released, so do the iommu table for the PE.
iommu_table is a part of PE struct. When PE is released, iommu_table will go with it as well. Why to make is a pointer? I would understand it if you added reference counting there but no - iommu_table's lifetime is equal to PE lifetime. -- Alexey