[PATCH 05/13] powerpc: Use list_add_(before|after) macros
From: Ken Helias <hidden>
Date: 2014-06-06 17:37:47
Also in:
lkml
Subsystem:
linux for powerpc (32-bit and 64-bit), the rest · Maintainers:
Madhavan Srinivasan, Linus Torvalds
From: Ken Helias <redacted> Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias <redacted> Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/lib/rheap.c | 2 +- arch/powerpc/mm/dma-noncoherent.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/lib/rheap.c b/arch/powerpc/lib/rheap.c
index a1060a8..d8c5f16 100644
--- a/arch/powerpc/lib/rheap.c
+++ b/arch/powerpc/lib/rheap.c@@ -486,7 +486,7 @@ unsigned long rh_alloc_align(rh_info_t * info, int size, int alignment, const ch spblk->start = blk->start; spblk->size = sp_size; /* add before the blk */ - list_add(&spblk->list, blk->list.prev); + list_add_before(&spblk->list, &blk->list); } newblk = get_slot(info); newblk->start = start;
diff --git a/arch/powerpc/mm/dma-noncoherent.c b/arch/powerpc/mm/dma-noncoherent.c
index d85e86a..222ae97 100644
--- a/arch/powerpc/mm/dma-noncoherent.c
+++ b/arch/powerpc/mm/dma-noncoherent.c@@ -120,7 +120,7 @@ ppc_vm_region_alloc(struct ppc_vm_region *head, size_t size, gfp_t gfp) /* * Insert this entry _before_ the one we found. */ - list_add_tail(&new->vm_list, &c->vm_list); + list_add_before(&new->vm_list, &c->vm_list); new->vm_start = addr; new->vm_end = addr + size;
--
2.0.0