Thread (24 messages) 24 messages, 3 authors, 2014-05-21

Re: [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave

From: Hongbo Zhang <hidden>
Date: 2014-05-04 08:40:29
Also in: lkml

On 05/03/2014 12:51 AM, Vinod Koul wrote:
On Fri, Apr 18, 2014 at 04:17:50PM +0800, hongbo.zhang@freescale.com wrote:
quoted
From: Hongbo Zhang <redacted>

The usage of spin_lock_irqsave() is a stronger locking mechanism than is
required throughout the driver. The minimum locking required should be used
instead. Interrupts will be turned off and context will be saved, it is
unnecessary to use irqsave.

This patch changes all instances of spin_lock_irqsave() to spin_lock_bh(). All
manipulation of protected fields is done using tasklet context or weaker, which
makes spin_lock_bh() the correct choice.
This doesnt apply, perhpas due to depends on 6/8
So let's wait for the review result of 6/8.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help