On 03/28/2014 11:44 AM, Hongbo Zhang wrote:

On 03/11/2014 07:06 PM, Vinod Koul wrote:

quoted

On Thu, Jan 16, 2014 at 01:47:22PM +0800, hongbo.zhang@freescale.com 
wrote:

quoted

From: Hongbo Zhang <redacted>

There are several places where descriptors are freed using identical 
code.
This patch puts this code into a function to reduce code duplication.

Signed-off-by: Hongbo Zhang <redacted>
Signed-off-by: Qiang Liu <redacted>
---
  drivers/dma/fsldma.c |   38 ++++++++++++++++++++------------------
  1 file changed, 20 insertions(+), 18 deletions(-)

diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 95236e6..ad73538 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c

@@ -418,6 +418,21 @@ static dma_cookie_t fsl_dma_tx_submit(struct 

dma_async_tx_descriptor *tx)
  }
    /**
+ * fsl_dma_free_descriptor - Free descriptor from channel's DMA pool.
+ * @chan : Freescale DMA channel
+ * @desc: descriptor to be freed
+ */
+static void fsl_dma_free_descriptor(struct fsldma_chan *chan,
+        struct fsl_desc_sw *desc)
+{
+    list_del(&desc->node);
+#ifdef FSL_DMA_LD_DEBUG
+    chan_dbg(chan, "LD %p free\n", desc);
+#endif

why not wrap the define stuff in the defination of chan_dbg rather 
than its
usage :(

OK, I will fix it by another separate patch.
Thanks.

Think it again, I'd like to remove the FSL_DMA_LD_DEBUG usage, because 
the chan_dbg is a wrapper of dev_dbg, we do have macro to switch on/off 
dev_dbg, and most of other codes are calling chan_dbg directly without 
FSL_DMA_LD_DEBUG, the FSL_DMA_LD_DEBUG only shows up 3 times unnecessarily.

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev