Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

On Wednesday 12 February 2014, Sebastian Hesselbarth wrote:

On 02/12/2014 12:38 AM, Stephen N Chivers wrote:

quoted

Sebastian Hesselbarth [off-list ref] wrote on

quoted

quoted

I don't think the missing compatible is causing it, but of_serial
provides a DT match for .type = "serial" just to fail later on
with the error seen above.

The commit in question reorders of_match_device in a way that match
table order is not relevant anymore. This can cause it to match
.type = "serial" first here.

Rather than touching the commit, I suggest to remove the problematic
.type = "serial" from the match table. It is of no use anyway.

Deleting the "serial" line from the match table fixes the problem.
I tested it for both orderings of compatible.

I revert my statement about removing anything from of_serial.c. Instead
we should try to prefer matches with compatibles over type/name without
compatibles. Something like the patch below (compile tested only)

That would probably be a good idea. However, I think in this
case we also want to remove the line from the driver, as it clearly
never works on any hardware and the driver just errors out for the
device_type match.

	Arnd