Re: [PATCH] powerpc: warn users of smt-snooze-delay that the API isn't there anymore
From: Cody P Schafer <hidden>
Date: 2014-02-25 22:47:32
Also in:
lkml
From: Cody P Schafer <hidden>
Date: 2014-02-25 22:47:32
Also in:
lkml
On 02/24/2014 08:53 PM, Madhavan Srinivasan wrote:
On Saturday 22 February 2014 05:44 AM, Cody P Schafer wrote:quoted
/sys/devices/system/cpu/cpu*/smt-snooze-delay was converted into a NOP in commit 3fa8cad82b94d0bed002571bd246f2299ffc876b, and now does nothing. Add a pr_warn() to convince any users that they should stop using it. The commit message from the removing commit notes that this functionality should move into the cpuidle driver, essentially byWould prefer to cleanup the code since the functionality is moved, instead of adding to it.
We'd still want users of the interface to use an attribute wired up under the cpuidle/ dir, so a warning (to update their software) is still needed. As deepthi has noted, cpuidle right now doesn't support changing this on a per-cpu basis, so a "cleanup" isn't a simple matter.