Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()
From: Daniel Lezcano <hidden>
Date: 2014-01-27 17:12:55
Also in:
linux-arm-kernel, linux-pm, linux-sh, lkml
On 01/27/2014 05:07 PM, Russell King - ARM Linux wrote:
On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote:quoted
On 01/27/2014 07:08 AM, Nicolas Pitre wrote:quoted
ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call local_fiq_enable(). We have secondary_start_kernel() already calling local_fiq_enable() and this is done a second time in arch_cpu_idle_prepare() in that case. And enabling FIQs has nothing to do with idling the CPU to start with. So let's introduce init_fiq_boot_cpu() to take care of FIQs on the boot CPU and remove arch_cpu_idle_prepare(). This is now done a bit earlier at late_initcall time but this shouldn't make a difference in practice i.e. when FIQs are actually used. Signed-off-by: Nicolas Pitre <redacted>Reviewed-by: Daniel Lezcano <redacted>What kind of review did you do when giving that attributation?
I did the review to the best of my knowledge and with good will. I read your comment on this patch and I learnt one more thing. Today, I am smarter than yesterday and dumber than tomorrow :) -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog