Thread (2 messages) flat view 2 messages, 2 authors, 2014-01-16

Re: [PATCH v2] drivers/tty/hvc: don't use module_init in non-modular hyp. console code

From: David Vrabel <hidden>
Date: 2014-01-16 10:47:44
Also in: lkml

On 15/01/14 21:35, Paul Gortmaker wrote:
The HVC_OPAL/RTAS/UDBG/XEN options are all bool, and hence their support
is either present or absent.  It will never be modular, so using
module_init as an alias for __initcall is rather misleading.

Fix this up now, so that we can relocate module_init from
init.h into module.h in the future.  If we don't do this, we'd
have to add module.h to obviously non-modular code, and that
would be a worse thing.

Note that direct use of __initcall is discouraged, vs. one
of the priority categorized subgroups.  As __initcall gets
mapped onto device_initcall, our use of device_initcall
directly in this change means that the runtime impact is
zero -- it will remain at level 6 in initcall ordering.

Also the __exitcall functions have been outright deleted since
they are only ever of interest to UML, and UML will never be
using any of this code.
For the hvc_xen changes

Acked-by: David Vrabel <redacted>

Thanks

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help