On 08/01/14 20:26, Greg Kroah-Hartman wrote:

On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:

quoted

From: Sudeep Holla <redacted>

This patch adds initial support for providing processor cache informatio=

n

quoted

to userspace through sysfs interface. This is based on x86 implementatio=

n

quoted

and hence the interface is intended to be fully compatible.

A per-cpu array of cache information maintained is used mainly for
sysfs-related book keeping.

Signed-off-by: Sudeep Holla <redacted>
---
 drivers/base/Makefile     |   2 +-
 drivers/base/cacheinfo.c  | 296 +++++++++++++++++++++++++++++++++++++++=

+++++++

quoted

 include/linux/cacheinfo.h |  43 +++++++
 3 files changed, 340 insertions(+), 1 deletion(-)
 create mode 100644 drivers/base/cacheinfo.c
 create mode 100644 include/linux/cacheinfo.h

=20
You are creating sysfs files, yet you didn't add Documentation/ABI/
information, which is required.  Please fix that.
=20

Ah, I overlooked it. But I am not creating any new sysfs files in this seri=
es.
I am just trying to unify duplicated code in various architectures.

Since these sysfs files are already created in:
1. arch/ia64/kernel/topology.c
2. arch/powerpc/kernel/cacheinfo.c
3. arch/s390/kernel/cache.c
4. arch/x86/kernel/cpu/intel_cacheinfo.c and
also already used by user-space tools like `lscpu` I assumed it's already
documented.

I will add it in next version.

Regards,
Sudeep