Re: [PATCH v1 0/4] powerpc/512x: update COMMON_CLK support for MPC5125

From
Matteo Facchinetti <hidden>
Date
2013-12-12 16:18:03
Reply to
Gerhard Sittig, 2013-12-10
On 10/12/2013 14:11, Gerhard Sittig wrote:
this series improves the previously introduced common clock support for
MPC512x such that SoC variants 5123 and 5125 get addressed appropriately
(MPC5125 turned out to be rather different from MPC5121 than I perceived
before -- there is much more than "just two FECs and no MBX")
Ohhh yesss..... welcome to hell! :-)

I report also these differences:

- I/O control module:
       to do integration with linux pin-muxing subsystem

- GPIO module:
       controller is the same of the mpc5121 but with these differences:
       - 64 gpios divided in 2 banks
       - input only gpios are numbers form 0 to 3 of the first bank
       I'm finishing to write the patch... when done I'll post in ML

- NFC: one of the biggest unsolved mystery
       Is this ip-core used in others microcontrollers? Seems to be used only in mpc5125!!!
Matteo, can you verify the crystal frequency in the DTS update, please?
Crystal frequency is ok: 33MHz.
And that v3.13-rc kernels with v6 of the COMMON_CLK introduction for
MPC512x plus this series for MPC5125 operate your peripherals, both with
an updated device tree as well as with a former device tree that lacks
clock specs?  Thank you!  Setting CONFIG_COMMON_CLK_DEBUG=y in your
.config and eyeballing /sys/kernel/debug/clk/clk_summary will help you.
I tested all on TWR board.

In DTS, for the moment, have to comment out this block:
-        usb@3000 {
-            compatible = "fsl,mpc5121-usb2-dr";
-            reg = <0x3000 0x400>;
-            #address-cells = <1>;
-            #size-cells = <0>;
-            interrupts = <43 0x8>;
-            dr_mode = "host";
-            phy_type = "ulpi";
-            clocks = <&clks MPC512x_CLK_USB1>;
-            clock-names = "ipg";
-        };
Because USB controller pinout is not initialized correctly and when system boot, causes a kernel panic.

For the rest, kernel works correctly. For MPC5125 the patches are OK.

I also check clk_summary and all clocks values are OK (except for NFC clock value).

I notice that there are missing clock like: gpio1, gpio2, fuse, dma,  wdt, pmc, rtc.
Is this OK or should be added?


Regards,

Matteo Facchinetti
Sirius Electronic Systems
Thread (12 messages) 12 messages, 6 authors, last reply 2013-12-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help