Thread (5 messages) flat view 5 messages, 3 authors, 2013-12-06

Re: [PATCH RFC v4 2/5] dma: mpc512x: add support for peripheral transfers

From: Alexander Popov <hidden>
Date: 2013-12-06 20:41:07

2013/12/7 Lars-Peter Clausen [off-list ref]:
On 12/06/2013 09:27 PM, Alexander Popov wrote:
quoted
2013/10/6 Gerhard Sittig [off-list ref]:
   * struct dma_slave_config - dma slave channel runtime config
   * @direction: whether the data shall go in or out on this slave
   * channel, right now. DMA_TO_DEVICE and DMA_FROM_DEVICE are
   * legal values, DMA_BIDIRECTIONAL is not acceptable since we
   * need to differentiate source and target addresses.
   ...
   struct dma_slave_config {
           enum dma_transfer_direction direction;
           ...
   };

The comment above the definition is obsolete, isn't it?

Yes, the comment seems to be out of date. Care to send a patch fixing it?
Yes, I will prepare and send the patch.

Thanks
Alexander
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help