Re: [PATCH v2 6/9] intel_idle: do C1E promotion disable quirk for hotplugged CPUs

From
Daniel Lezcano <hidden>
Date
2013-12-20 21:52:36
Also in
linux-pm, linux-samsung-soc, lkml
Reply to
Bartlomiej Zolnierkiewicz, 2013-12-20
On 12/20/2013 07:47 PM, Bartlomiej Zolnierkiewicz wrote:
If the system is booted with some CPUs offline C1E promotion disable quirk
won't be applied because on_each_cpu() in intel_idle_cpuidle_driver_init()
operates only on online CPUs. Fix it by adding the C1E promotion disable
handling to intel_idle_cpu_init() (which is also called during CPU_ONLINE
operation).

Signed-off-by: Bartlomiej Zolnierkiewicz <redacted>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Len Brown <lenb@kernel.org>
Reviewed-by: Daniel Lezcano <redacted>
quoted hunk ↗ jump to hunk
---
  drivers/idle/intel_idle.c | 3 +++
  1 file changed, 3 insertions(+)
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index 92d1206..38da3fb 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -683,6 +683,9 @@ static int intel_idle_cpu_init(int cpu)
  	if (icpu->auto_demotion_disable_flags)
  		smp_call_function_single(cpu, auto_demotion_disable, NULL, 1);

+	if (icpu->disable_promotion_to_c1e)
+		smp_call_function_single(cpu, c1e_promotion_disable, NULL, 1);
+
  	return 0;
  }
-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Thread (21 messages) 21 messages, 5 authors, last reply 2014-01-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help