Re: [PATCH 1/3] powerpc: Enable emulate_step In Little Endian Mode

On 10/30/2013 2:43 PM, Geert Uytterhoeven wrote:

On Wed, Oct 30, 2013 at 8:35 PM, Tom Musta [off-list ref] wrote:

quoted

On 10/30/2013 12:43 PM, Andreas Schwab wrote:

quoted

Tom Musta [off-list ref] writes:

quoted

+#ifdef __LITTLE_ENDIAN__
+       if (!regs->msr & MSR_LE)

That won't work.

Andreas.

Please elaborate.

You want to test for "!(regs & MSR_LE)".

Gr{oetje,eeting}s,

                         Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                 -- Linus Torvalds

Thanks Adnreas and Geert.  I will fix and resubmit.