Thread (7 messages) 7 messages, 3 authors, 2013-10-11

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

From: Brian Norris <computersforpeace@gmail.com>
Date: 2013-10-11 17:33:33

Hi,

On Thu, Oct 10, 2013 at 12:37 PM, Anatolij Gustschin [off-list ref] wrote:
On Thu, 10 Oct 2013 11:23:55 -0700
Brian Norris [off-list ref] wrote:
quoted
quoted
Yes, we also have to remove CONFIG_FB_FSL_DIU ifdef in
arch/powerpc/sysdev/fsl_soc.h and building should work then.
Still want it around this line, probably, so we'll get compiler errors
and not linker errors if someone tries to use it?

    extern struct platform_diu_data_ops diu_ops;
I was wrong about this: we need to remove the #ifdef for this extern
as well, because the 'diu_ops' symbol is used in either case with my
patch. Sending out my patch now.

Brian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help