Re: [PATCH 2/3] sched: Fix asymmetric scheduling for POWER7
From: Peter Zijlstra <peterz@infradead.org>
Date: 2013-10-22 22:18:21
Also in:
lkml
On Mon, Oct 21, 2013 at 05:14:52PM +0530, Vaidyanathan Srinivasan wrote:
quoted hunk ↗ jump to hunk
kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 12f0eab..828ed97 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c@@ -5821,8 +5821,8 @@ static inline int nohz_kick_needed(struct rq *rq, int cpu) goto need_kick_unlock; } - if (sd->flags & SD_ASYM_PACKING && nr_busy != sg->group_weight - && (cpumask_first_and(nohz.idle_cpus_mask, + if (sd->flags & SD_ASYM_PACKING && + (cpumask_first_and(nohz.idle_cpus_mask, sched_domain_span(sd)) < cpu)) goto need_kick_unlock;
Ahh, so here you remove the nr_busy usage.. this patch should really go before the first one that makes this all weird and funny.