Re: [v5][PATCH 4/6] powerpc/book3e: support kgdb for kernel space
From: Scott Wood <hidden>
Date: 2013-10-18 22:58:56
Also in:
lkml
On Thu, 2013-06-20 at 18:28 +0800, Tiejun Chen wrote:
Currently we need to skip this for supporting KGDB.
Does it need to depend on CONFIG_KGDB? Either you've fixed the "can't quite save properly" part, or you haven't. -Scott
quoted hunk ↗ jump to hunk
Signed-off-by: Tiejun Chen <redacted> --- arch/powerpc/kernel/exceptions-64e.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S index 07cf657..a286b51 100644 --- a/arch/powerpc/kernel/exceptions-64e.S +++ b/arch/powerpc/kernel/exceptions-64e.S@@ -639,11 +639,13 @@ kernel_dbg_exc: rfdi /* Normal debug exception */ +1: andi. r14,r11,MSR_PR; /* check for userspace again */ +#ifndef CONFIG_KGDB /* XXX We only handle coming from userspace for now since we can't * quite save properly an interrupted kernel state yet */ -1: andi. r14,r11,MSR_PR; /* check for userspace again */ beq kernel_dbg_exc; /* if from kernel mode */ +#endif /* Now we mash up things to make it look like we are coming on a * normal exception