Re: [PATCH v3 3/3] powerpc/85xx: use one kernel option for all the CoreNet_Generic boards
From: Kevin Hao <hidden>
Date: 2013-09-26 01:23:24
Subsystem:
linux for powerpc (32-bit and 64-bit), linux for powerpc embedded ppc85xx, the rest · Maintainers:
Madhavan Srinivasan, Scott Wood, Linus Torvalds
On Wed, Sep 25, 2013 at 06:11:23PM -0500, Scott Wood wrote:
On Wed, 2013-09-25 at 08:58 +0800, Kevin Hao wrote:quoted
On Tue, Sep 24, 2013 at 05:41:32PM -0500, Scott Wood wrote:quoted
On Tue, 2013-09-24 at 11:03 +0800, Kevin Hao wrote:quoted
+ and B4 QDS boards[...]quoted
Is there any difference between the 32-bit and 64-bit versions of this config symbol, other than the help text?No. As you know some of these boards only support 32bit kernel and some of them only support 64bit kernel. It will definitely cause confusion when using only one kernel option for all these boards. So I divide this into two options (even the same name) for 32bit and 64bit respectively.You could just mention in the help text which boards are 32-bit, which are 64-bit, and which can work with either.
OK. How about this? arch/powerpc/platforms/85xx/Kconfig | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
index 04456fb..4d46349 100644
--- a/arch/powerpc/platforms/85xx/Kconfig
+++ b/arch/powerpc/platforms/85xx/Kconfig@@ -218,20 +218,6 @@ config GE_IMP3A This board is a 3U CompactPCI Single Board Computer with a Freescale P2020 processor. -config CORENET_GENERIC - bool "Freescale CoreNet Generic" - select DEFAULT_UIMAGE - select PPC_E500MC - select PHYS_64BIT - select SWIOTLB - select ARCH_REQUIRE_GPIOLIB - select GPIO_MPC8XXX - select HAS_RAPIDIO - select PPC_EPAPR_HV_PIC - help - This option enables support for the P2041 RDB, P3041 DS, P4080 DS, P5020 DS - and P5040 DS boards - config SGY_CTS1000 tristate "Servergy CTS-1000 support" select GPIOLIB
@@ -257,8 +243,6 @@ config PPC_QEMU_E500 unset based on the emulated CPU (or actual host CPU in the case of KVM). -if PPC64 - config CORENET_GENERIC bool "Freescale CoreNet Generic" select DEFAULT_UIMAGE
@@ -271,10 +255,14 @@ config CORENET_GENERIC select HAS_RAPIDIO select PPC_EPAPR_HV_PIC help - This option enables support for the P5020 DS, P5040 DS, T4240 QDS - and B4 QDS boards + This option enables support for the FSL CoreNet based boards. + For 32bit kernel, the following boards are supported: + P2041 RDB, P3041 DS and P4080 DS + For 64bit kernel, the following boards are supported: + T4240 QDS and B4 QDS + The following boards are supported for both 32bit and 64bit kernel: + P5020 DS and P5040 DS -endif endif # FSL_SOC_BOOKE config TQM85xx
Thanks, Kevin
-Scott
Attachments
- (unnamed) [application/pgp-signature] 490 bytes