Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x

On Mon, 2013-09-16 at 21:11 -0500, Kushwaha Prabhakar-B32579 wrote:

quoted

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, September 17, 2013 2:49 AM
To: Kushwaha Prabhakar-B32579
Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org;
galak@kernel.crashing.org; Aggrwal Poonam-B10812; Jain Priyanka-B32167;
Sethi Varun-B16395
Subject: Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of
T104x

On Fri, 2013-09-13 at 02:30 -0500, Kushwaha Prabhakar-B32579 wrote:

quoted

quoted

I also question the need to define separate t1040 compatible values
for all of these, if the only difference is whether the onboard
switch is enabled or not.

so should I use T104x as compatible field. and in T1040 device tree add

extra node for l2 switch.

I am using T1042 as base dts and T1040 includes T1040 + l2switch. 

so if I use T1042 in compatible. It will give wrong field for someone working on T1040QDS.

What is wrong about it?  It is compatible, right?

-Scott